Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove gmd series tag #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix/remove gmd series tag #33

wants to merge 4 commits into from

Conversation

silvia-starnini
Copy link

Creating or updating a service metadata a gmd:series tag was created by mistake: in update-fixed-info we fixed this issue separating behaviour for dataset and service metadata

etj
etj reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@etj etj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of replicating code (and removing some apply-templates instructions, so potentially losing some info from the metadata), I guess that it would be better to add a test for dataset/series before adding the automatically computed issueIdentification (https:/metadata101/iso19139.rndt/pull/33/files#diff-f8c99d140c17ea427978f68d8fa7b705ebc4a7ecb877a9014c7744cc22fe35e3R324-R335)

@silvia-starnini
Copy link
Author

Thank you for your answer, we're going to check our code for a better solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etj etj etj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvia-starnini @etj