Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smallest property #86

Merged
merged 6 commits into from
Sep 11, 2018
Merged

Conversation

lhuggett
Copy link
Contributor

@lhuggett lhuggett commented Aug 1, 2018

New class method in TimePoint class to find the next smallest property that is missing from a truncated representation. Required for use with relative Initial Cycle Point in Cylc.

@matthewrmshin
Copy link
Member

Need some tests?

@matthewrmshin
Copy link
Member

Hi @lhuggett please add your name to CONTRIBUTING.md - since this is the 1st time you make a contribution to this repository.

@matthewrmshin
Copy link
Member

(Just need to add your name to CONTRIBUTING.md and you are done.)

@matthewrmshin
Copy link
Member

@oliver-sanders please sanity check.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one minor comment which can be ignored.

isodatetime/data.py Show resolved Hide resolved
@matthewrmshin matthewrmshin merged commit 61fac8d into metomi:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants