Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laravel-10 support and fix required version format #186

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

txdFabio
Copy link
Contributor

fixed compose require version format and addedd laravel-10 support

@txdFabio txdFabio mentioned this pull request Feb 15, 2023
Copy link

@ali-alharthi ali-alharthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpunit should also include 10:
"phpunit/phpunit": "^8.0|^9.0|^10",

@txdFabio
Copy link
Contributor Author

phpunit should also include 10: "phpunit/phpunit": "^8.0|^9.0|^10",

done!

@faytekin
Copy link

@mewebstudio ping

@fabiofdsantos
Copy link

ping @mewebstudio

@digitv
Copy link

digitv commented Feb 21, 2023

@mewebstudio ping

@tabacitu
Copy link
Contributor

Thanks for the PR @txdFabio 🙏 With your PR, Purifier::clean() function works just as fine in our L10 tests!

@mewebstudio when can we expect a merge & tag?

@kminek
Copy link

kminek commented Feb 23, 2023

@mewebstudio are you okay? i noticed that you're from Turkey and there were some serious earthquakes there...

@pxpm
Copy link

pxpm commented Feb 27, 2023

@mewebstudio are you okay? i noticed that you're from Turkey and there were some serious earthquakes there...

I don't think the person is living in the affected area of the earthquake. If they didn't go to that area during the earthquake, they shouldn't have been affected.

I think that's a very rude way of putting up the issue. People have family, friends and empathy with other human beings.

There are many ways to get affected by the events, even if living in another country.

I make @kminek my words, and hope @mewebstudio , his relatives and friends are all ok 🙏

Also I am here with all other developers in the hopes that we can help @mewebstudio to merge this PR 👍

Cheers

@ali-alharthi
Copy link

If you're in a hurry, you can always find other packages or fork this one. For example the following stevebauman/purify.
Good luck.

@eduardopilati
Copy link

If you're in a hurry, you can always find other packages or fork this one. For example the following stevebauman/purify. Good luck.

or making your own fork

@mewebstudio mewebstudio merged commit 53120f3 into mewebstudio:master Mar 14, 2023
@txdFabio
Copy link
Contributor Author

I've seen you have merged the PR, thanks.
Can you also tag for a new release, please?

This was referenced Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.