-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel off wrong event #35
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/// Removes an event callback
void off(event, [ref]) {
_bindings = _bindings
.where((binding) =>
binding.event != event && (ref == null || ref == binding.ref))
.toList();
}
I thing the right code must be:
/// Removes an event callback
/// Keep difference event or event with difference ref
void off(event, [ref]) {
_bindings = _bindings
.where((binding) =>
binding.event != event || ![binding.ref, null].contains(ref))
.toList();
}
The text was updated successfully, but these errors were encountered: