Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel off wrong event #35

Open
VanLong-official opened this issue Mar 16, 2023 · 0 comments
Open

Channel off wrong event #35

VanLong-official opened this issue Mar 16, 2023 · 0 comments

Comments

@VanLong-official
Copy link

  • If I have 2 sites A and B both join the same channel and same event. I disabled the event on site B and wanted to keep that callback on site A but couldn't. When I open the reading library, this function is written as follows:
    /// Removes an event callback
    void off(event, [ref]) {
    _bindings = _bindings
    .where((binding) =>
    binding.event != event && (ref == null || ref == binding.ref))
    .toList();
    }
    I thing the right code must be:
    /// Removes an event callback
    /// Keep difference event or event with difference ref
    void off(event, [ref]) {
    _bindings = _bindings
    .where((binding) =>
    binding.event != event || ![binding.ref, null].contains(ref))
    .toList();
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant