Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it possible to pass socket options as named args #9

Merged
merged 1 commit into from
Nov 20, 2018
Merged

make it possible to pass socket options as named args #9

merged 1 commit into from
Nov 20, 2018

Conversation

lesnitsky
Copy link
Contributor

Thanks for this package

as flutter dev I was confused with lack of possibility to pass options as named args. Consider adding this to the API 😏

@mfeckie mfeckie merged commit b246a98 into mfeckie:master Nov 20, 2018
@lesnitsky
Copy link
Contributor Author

@mfeckie could you also publish a release with this change?

@mfeckie
Copy link
Owner

mfeckie commented Nov 20, 2018 •
edited
Loading

You might have to give me a few days as I'm changing laptop and haven't got my access keys for pub setup yet

@lesnitsky
Copy link
Contributor Author

No problem, thanks

@mfeckie
Copy link
Owner

mfeckie commented Nov 20, 2018

Actually, I published it just now.

@lesnitsky
Copy link
Contributor Author

Kudos!

@lesnitsky lesnitsky deleted the socket-options-args branch November 23, 2018 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfeckie mfeckie mfeckie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesnitsky @mfeckie