Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test files are not checked in dot-imports #883

Closed
denisvmedia opened this issue Aug 29, 2023 · 1 comment · Fixed by #884
Closed

Test files are not checked in dot-imports #883

denisvmedia opened this issue Aug 29, 2023 · 1 comment · Fixed by #884

Comments

@denisvmedia
Copy link
Collaborator

Describe the bug
We would like to have no exceptions even for test files on dot-imports. Unfortunately, the linter rule has a hard-coded check disabled.

To Reproduce
Have a _test.go file with dot imports and try using the linter.

Expected behavior
Linter should detect those.

Additional context
We might have it as a config option set by default to ignore test files or just remove the hardcoded check and let the users re-configure their linters to ignore tests separately.

I can provide a PR if you agree.

@chavacava
Copy link
Collaborator

Hi @denisvmedia thanks for creating the ticket.
I think we can just remove the hardcoded check and let users use the new exclude argument available on all rules.

A PR is welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants