Normalize the paths of all files, avoiding duplicate misses of directories #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectories. For example with Products.PloneHelpCenter (on github) I get this report, where in all cases the directories are there and have a file in them: missing from VCS: Products/PloneHelpCenter/profiles/default/workflows/helpcenter_workflow/ Products/PloneHelpCenter/profiles/default/workflows/helpcenterfolder_workflow/ Products/PloneHelpCenter/profiles/default/workflows/helpcentersubitem_workflow/ missing from sdist: Products/PloneHelpCenter/profiles/default/workflows/helpcenter_workflow Products/PloneHelpCenter/profiles/default/workflows/helpcenterfolder_workflow Products/PloneHelpCenter/profiles/default/workflows/helpcentersubitem_workflow
|
Looks good to me. It would be enough to change with tarfile.open(archive_filename) as tf:
# Sometimes directory names in tar files have trailing slashes,
# and sometimes they don't. Sometimes you get both in the same
# archive.
return strip_slashes(tf.getnames())but, on the other hand, always using |
mgedmin
added a commit
that referenced
this pull request
Sep 20, 2013
…ories Normalize the paths of all files, avoiding duplicate misses of directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example with Products.PloneHelpCenter I get this report, where in all cases the directories are there and have a file in them:
missing from VCS:
Products/PloneHelpCenter/profiles/default/workflows/helpcenter_workflow/
Products/PloneHelpCenter/profiles/default/workflows/helpcenterfolder_workflow/
Products/PloneHelpCenter/profiles/default/workflows/helpcentersubitem_workflow/
missing from sdist:
Products/PloneHelpCenter/profiles/default/workflows/helpcenter_workflow
Products/PloneHelpCenter/profiles/default/workflows/helpcenterfolder_workflow
Products/PloneHelpCenter/profiles/default/workflows/helpcentersubitem_workflow