Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .cast() instead of "as *mut _" #33

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Use .cast() instead of "as *mut _" #33

merged 1 commit into from
Jul 7, 2023

Conversation

mgeier
Copy link
Owner

@mgeier mgeier commented Jan 16, 2021 •
edited
Loading

I'm not sure whether that's considered to be better, any opinions?

@mgeier
Copy link
Owner Author

mgeier commented Jan 16, 2021

OK, looks like the .cast() method has been added in 1.38, but our MSRV is 1.36.

I guess this isn't worth bumping the MSRV for, so I will not merge this for now.

@mgeier mgeier marked this pull request as draft January 16, 2021 20:48
@mgeier mgeier closed this Feb 3, 2021
@mgeier mgeier reopened this Apr 10, 2021
@mgeier mgeier marked this pull request as ready for review July 6, 2023 17:37
@mgeier
Copy link
Owner Author

mgeier commented Jul 6, 2023

In the meantime, the MSRV has been bumped to 1.38, so now we can merge this.

@mgeier mgeier merged commit 20d8e56 into mgeier:main Jul 7, 2023
9 checks passed
@mgeier mgeier deleted the cast branch July 7, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgeier