Fix for null selectors and respecting specificity. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed some stuff to make it more distinguishable
Feature is deprecated in ruby sass. We may should print a warning to inform the user. Fixes sass#1258
Missing implementation for interpolated media queries!
Missing implementation for interpolated namespaces!
Re-armed the error handling and slightly cleaned up main block parsing function. Includes hash improvement for list as keys
|
Do you have a test case for this? |
|
yes, I can provide one. Would you like me to add it to sass-spec? |
|
Would be great. But please also post it here as I'm currently rebasing the whole PR and would like to test what your commits actually fix. |
mgreter
force-pushed
the
refactoring/parser-for-3.3
branch
6 times, most recently
from
bc9de62
to
659e4cb
Compare
.simple {
a: selector-replace('foo.bar', 'foo', 'foo[baz]');
} |
|
expected output: .simple {
a: foo.bar[baz]; } |
|
Also for the child-selector issue: foo {
a:&;
>bar {
b:&;
>baz {
c:&;
}
}
}expected output: foo {
a: foo; }
foo > bar {
b: foo > bar; }
foo > bar > baz {
c: foo > bar > baz; } |
|
ugh...sorry about the formatting.... |
|
I have cherry picked your commits and removed a few more bits! Thank you! |
mgreter
force-pushed
the
refactoring/parser-for-3.3
branch
from
95c72c2
to
5776e9b
Compare
mgreter
force-pushed
the
refactoring/parser-for-3.3
branch
5 times, most recently
from
a4237dd
to
962a45e
Compare
ekskimn
referenced
this pull request
Jul 10, 2015
mgreter
force-pushed
the
refactoring/parser-for-3.3
branch
2 times, most recently
from
0dccd10
to
3af051e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.