Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons/markers are not in the right place (isometric render) #24

Open
Dinip opened this issue Dec 28, 2023 · 2 comments
Open

Icons/markers are not in the right place (isometric render) #24

Dinip opened this issue Dec 28, 2023 · 2 comments

Comments

@Dinip
Copy link

Dinip commented Dec 28, 2023

Related to #20 and mapcrafter#391, the markers in isometric view (all directions) are out of place.

This behavior can be observed in the attached printscreens and in the public map from hermitcraft.
The map is only rendered in top-left rotation, but I've tried locally with other rotations and the same happens.

Topdown:
chrome_so3zLPJIgB

Isometric top-left:
chrome_zKsv2Esz5M

@kevinwchang
Copy link

Hey, I'm the one who submitted PR #20 and it seemed to fix the marker and coordinate issues on my map of my 1.20 world, but like I said, I basically arrived at that "fix" by trial and error. Can you confirm you're using a recent version of mapcrafter that includes my changes and still having problems? Is yours a 1.20 world or something older?

@Dinip
Copy link
Author

Dinip commented Jan 7, 2024

Hi @kevinwchang,
I'm using my custom 1.20 version, which is a fork of miclav's. I saw your PR #20 and made sure that my version had that commit before creating this issue.
Also did a render with miclav's version and in both cases, the markers were not in the right place.
The following examples are from the same world, in 1.20 build from miclav's docker.

Topdown top-left (marker on the right spot):
Topdown top-left

Topdown top-right:
Topdown top-right

Isometric top-left:
Isometric top-left

Isometric top-right:
Isometric top-right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants