Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log delta count in addition to throughput in LoggingMeterRegistry #5590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Log delta count in addition to throughput in LoggingMeterRegistry #5590

wants to merge 3 commits into from
+158 −16

Conversation

fstaudt
Copy link

@fstaudt fstaudt commented Oct 14, 2024

Closes #5548

shakuzen
shakuzen approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request and quick action on review. This looks good to me. We'll have to wait to merge until we start 1.15 development on main.

@jonatan-ivanov
Copy link
Member

What do you think about calling it delta instead of delta_count?

@fstaudt
Copy link
Author

fstaudt commented Oct 16, 2024 •
edited
Loading

Thanks for the pull request and quick action on review. This looks good to me. We'll have to wait to merge until we start 1.15 development on main.

Thanks for your quick review.

I was hoping that this change could still be part of 1.14.0 GA.
What is the reason that it should wait for 1.15 ?

@fstaudt
Copy link
Author

fstaudt commented Oct 16, 2024

What do you think about calling it delta instead of delta_count?

I woud keep delta_count in the logs.
The internal field is named count, it feels right to keep count in the logs.
If we only keep delta, it would make it less clear for users that it is a indeed a count.

@shakuzen
Copy link
Member

I was hoping that this change could still be part of 1.14.0 GA.
What is the reason that it should wait for 1.15 ?

Our general policy is that we do not merge enhancements after a release candidate is released. 1.14.0-RC1 was released yesterday, so the next opportunity for enhancements is 1.15.0-M1.

@fstaudt
Copy link
Author

fstaudt commented Oct 16, 2024

I've noticed a discrepancy in logs for counters between delta_count and throughput when baseUnit is set.
I've added an extra commit with updated unit tests to fix this.

@fstaudt
Copy link
Author

fstaudt commented Oct 16, 2024

Our general policy is that we do not merge enhancements after a release candidate is released. 1.14.0-RC1 was released yesterday, so the next opportunity for enhancements is 1.15.0-M1.

OK, clear.

Do you already have an estimation of release date for 1.15.0 GA ?
It would help me for internal communication.

@jonatan-ivanov
Copy link
Member

We have a 6 months minor release cycle, based on our current release schedule, 1.15.0 should go GA around the second Monday of May (12th) but you might be able to use 1.15.0-M1 in January.

@shakuzen
Copy link
Member

I've gone ahead and added tentative dates for 1.15 to our support page: https://micrometer.io/support/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log delta count in addition to throughput in LoggingMeterRegistry
3 participants
@fstaudt @jonatan-ivanov @shakuzen