-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [R-package] incorrect R version being used on some R-package CI jobs #5640
Comments
The correct version is being used on macOS and Linux CI jobs, per this: LightGBM/.ci/test_r_package.sh Lines 234 to 241 in 646dfed
So only Windows checks need to still be added. I'll put up a PR for that shortly. |
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https:/microsoft/LightGBM/issues including a reference to this. |
Description
At least on Linux,
r-package
CI jobs in this project appear to be using the wrong R version.For example, on the most recent
r-package (ubuntu-22.04, gcc, R 3.6, cmake
build onmaster
(build link), I see the following in the logs.and
This means that at least for some combinations of operating system, compiler, and build type, the R package is not actually being tested against R 3.6.
Reproducible example
I noticed this on
ubuntu-22.04
(ubuntu-latest
) Linux R 3.6 jobs, but it might be happening on others.Environment info
At least latest
master
(a174893), unsure how long this has been going on.Additional Comments
I suspect that this is happening because of a combination of the following:
setup.sh
andtest_r_package.sh
don't useset -e
, so if commands installing stuff fail and don't explicitlyexit
with a non-0 code, scripts will continue runningAt least for Linux jobs, I hope that #5638 will prevent this "silently fell back to software from GitHub Actions" issue.
To close this issue, CI checks should be added which explicitly confirm that the expected version of R was used, similar to
LightGBM/.ci/test_r_package.sh
Lines 256 to 272 in a174893
I remember @StrikerRUS recommended that in the past, but I can't find the comment to link to.
The text was updated successfully, but these errors were encountered: