ignore unknown parameters when loading from model file #6126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoralez
requested review from
guolinke,
jameslamb and
shiyu1994
as code owners
jameslamb
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Thanks very much for this! I think it'll really help people trying to use models from older versions with v4.x.
I'm supportive of this generally, just left one suggestion about the wording of the warning.
I think we should also get a review from @guolinke or @shiyu1994 before merging this.
Co-authored-by: James Lamb <[email protected]>
jmoralez
commented
Oct 5, 2023
jameslamb
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Makes sense to me, thank you!
But let's please get a review from @guolinke or @shiyu1994 before merging.
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https:/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues a warning when a parameter type is not found when loading a booster from a model file instead of raising an error.
Fixes #6082