Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Artifacts if project is using .NET SDK's built-in artifacts functionality #458

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Jun 21, 2023

If a user has opted into the .NET SDK's artifacts functionality by setting the MSBuild property UseArtifactsOutput, then disable Microsoft.Build.Artifacts since you would only want to be using one or the other.

Also enables the pipeline to run tests against .NET 7.0 and .NET 8 while no longer running against .NET Core 3

@jeffkl jeffkl requested a review from dsplaisted June 21, 2023 18:36
@jeffkl
Copy link
Contributor Author

jeffkl commented Jun 21, 2023

Related PR in .NET SDK to disable itself if Microsoft.Build.Artifacts is in use: dotnet/sdk#33470

…unctionality

If a user has opted into the .NET SDK's artifacts functionality by setting the MSBuild property UseArtifactsOutput, then disable Microsoft.Build.Artifacts since you would only want to be using one or the other.

Also enables the pipeline to run tests against .NET 7.0 and .NET 8.0
@jeffkl jeffkl force-pushed the disable-artifacts-when-using-built-in branch from f198ea9 to 4bcb458 Compare November 1, 2023 20:49
@jeffkl
Copy link
Contributor Author

jeffkl commented Nov 1, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeffkl jeffkl merged commit 809463b into microsoft:main Nov 1, 2023
5 checks passed
@jeffkl jeffkl deleted the disable-artifacts-when-using-built-in branch November 1, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants