This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Change ColumnSelector test #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As dicussed offline, issue #478 is actually not an issue, and we shouldn't allow OnnxTransformer/OnnxRunner to drop columns coming from the input of the pipeline, only drop columns that were created inside the pipeline that was exported to onnx.
So the ColumnSelector test that was disabled in the past, would still fail. But it was agreed that this is expected behavior, and that we shouldn't expect the output of OnnxRunner to be the same as ML.NET and ORT.
I reenable that test on this PR, but change it in order to only test that OnnxRunner drops the 'Sepal_Length2' that isn't in the input of the pipeline, but that was created inside the pipeline that was exported.