Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerToys Run] Searching without using accented characters should bring accentuated results too #4147

Closed
mxrsoon opened this issue Jun 6, 2020 · 9 comments
Assignees
Labels
Area-Localization issues regarding to Localization the application Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@mxrsoon
Copy link

mxrsoon commented Jun 6, 2020

Environment

Windows build number: 10.0.18363.836
PowerToys version: v0.18.2
PowerToy module for which you are reporting the bug (if applicable): PowerToys Run

Steps to reproduce

  1. Have a shortcut to an app that contains accented characters in it's name (ex.: Câmera).
  2. Search for it using non-accented characters (ex.: camera).

Expected behavior

The shortcut with accented characters in it's name should be displayed as a result, as Windows Search does.

Actual behavior

The shortcut with accented characters isn't one of the results.

Screenshots

Expected behavior:
expectedbehavior

Actual behavior:
currentbehavior

@htcfreek
Copy link
Collaborator

htcfreek commented Jun 6, 2020

What will be find if you search for a win32 application with accent in the name. I think they must be found.

Because for packaged apps only the localized name is available for search and on win32 applications it's the other way.

See #4146.

@mxrsoon
Copy link
Author

mxrsoon commented Jun 7, 2020

I will check later and give a feedback.

But I think it should match acented characters in any of the two names. For example, "settings" translates to "configurações" in Brazilian Portuguese, and finding it by searching for a substring of "configuracoes" is desirable as it's faster to type without the accents. Windows Search does that.

Edit:
That's why I think this isn't related to the issue you linked to. As it solves the case present in the screenshot, but not other cases.

@saahmedm saahmedm added Area-Localization issues regarding to Localization the application Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels Jun 9, 2020
@saahmedm saahmedm added this to the v1.0 Release milestone Jun 9, 2020
@crutkas crutkas added Run-Plugin Things that relate with PowerToys Run's plugin interface Issue-Bug Something isn't working Priority-1 Bug that is high priority labels Nov 5, 2020
@crutkas
Copy link
Member

crutkas commented Nov 5, 2020

the work here would be in the program plugin. I'd be surprised if there wasn't some type of "best practice" here for this scenario

@crutkas
Copy link
Member

crutkas commented Nov 6, 2020

https://twitter.com/drosenwasser/status/1324501630390206464?s=21 has how we should pivot the query

@enricogior
Copy link
Contributor

@wazybr
is this still not working for you in 0.27?

@enricogior enricogior added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 9, 2020
@mxrsoon
Copy link
Author

mxrsoon commented Dec 12, 2020

@enricogior
Will check later today.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 12, 2020
@mxrsoon
Copy link
Author

mxrsoon commented Dec 12, 2020

@enricogior
Still not working.

Before accented character:
Captura de Tela (34)

After:
Captura de Tela (35)

@enricogior enricogior removed Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 12, 2020
@crutkas
Copy link
Member

crutkas commented Dec 14, 2020

From the twitter earlier:
https://stackoverflow.com/a/368850

string.Compare(s1, s2, CultureInfo.CurrentCulture, CompareOptions.IgnoreNonSpace | CompareOptions.IgnoreCase);

@crutkas
Copy link
Member

crutkas commented Dec 29, 2020

Fixed with 0.29, released today. https:/microsoft/PowerToys/releases/tag/v0.29.0

@crutkas crutkas closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Localization issues regarding to Localization the application Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

No branches or pull requests

6 participants