Rohde Schwarz ZNB /VNA refactor common code #887

Dominik-Vogel · 2017-11-28T16:04:42Z

In this pull request the common code from the two sweep classes gets refactored out.
The changes have not been tested with the instrument yet.

Additionally the channel class is abstracted into a class variable in the same way as in the decadac #876 to enable extention.
I also added a feature to automatically select the trace for the sweep when get is being called and restore the previous state on finalization.

Dominik-Vogel · 2017-11-28T16:23:46Z

This way of subclassing a parameter and overriding a method does not support the functionality of get_latest(). So we would need to add a _save_val/supply the get function via a kwarg or implement the warpper manually

Dominik-Vogel · 2017-11-28T16:31:50Z

Okay I jsut learned, that BaseParameter actually does the wrapping....

jenshnielsen · 2017-11-30T10:15:14Z

@Dominik-Vogel Looks like a nice cleanup. I would very much like this to be tested on an actual instrument before merging. @ThorvaldLarsen are you using the vna and able to test this

jenshnielsen · 2017-11-30T10:16:09Z

You might want to rename get -> get_raw to get rid of the deprecation warning

Dominik-Vogel · 2017-12-06T14:35:33Z

Thanks for the tip with get_raw! Yes surly do I want to test it before merging it.

ThorvaldLarsen · 2017-12-06T15:37:31Z

I can help with testing tomorrow afternoon if it is ready for testing by then.

codecov · 2017-12-15T10:09:10Z

Codecov Report

Merging #887 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #887   +/-   ##
=======================================
  Coverage   77.92%   77.92%           
=======================================
  Files          37       37           
  Lines        5236     5236           
=======================================
  Hits         4080     4080           
  Misses       1156     1156

ThorvaldLarsen · 2018-01-22T16:33:33Z

qcodes/instrument_drivers/rohde_schwarz/ZNB.py

@@ -68,7 +68,7 @@ def __init__(self, name, instrument, start, stop, npts, channel):
 label='{} magnitude'.format(
 instrument._vna_parameter),
 setpoint_units=('Hz',),
- setpoint_names=('{}_frequency'.format(instrument._vna_parameter),))


This is a mistake by me. Should be '{}_frequency' with the '_'.

ThorvaldLarsen · 2018-01-23T13:22:26Z

qcodes/instrument_drivers/rohde_schwarz/ZNB.py

+ # source power is dependent on model, but not well documented.
+ # here we assume -60 dBm for ZNB20, the others are set,
+ # due to lack of knowledge, to -80 dBm as of before the edit
+ model = self._instrument.get_idn()['model'].split('-')[0]


model = self._parent.get_idn()['model'].split('-')[0]

good point, thanks 👍

ThorvaldLarsen · 2018-01-24T10:24:21Z

@Dominik-Vogel I just remembered a somewhat minor thing but now that we are redoing the driver we might as well add it.
The bandwidth can only be set in steps 1/1.5/2/3/5/7, i.e. 1kHz, 700Hz, 15Hz etc. That is 280Hz will be set to the nearest step in this case 300Hz.
Is it possible to make a parser that checks if the number is allowed and if not reports back the actual value being set on the VNA?

See page 4 in https://cdn.rohde-schwarz.com/pws/dl_downloads/dl_common_library/dl_brochures_and_datasheets/pdf_1/service_support_30/ZNB_dat-sw_en_5214-5384-22_v0900_96dp.pdf

WilliamHPNielsen · 2018-01-24T11:56:26Z

@ThorvaldLarsen Sorry to jump in in the middle of a discussion, but I just caught a glimpse of something that sounds dangerous. Behaviour like

my_inst.my_param(100)  # actually sets it to 120

is in my opinion very bad and should be avoided. Either you input a correct value and have that exact value (modulo rounding errors and noise) realised on the instrument or you get an error and nothing happens on the insturment. As you most likely know, this is handled by validators.

ThorvaldLarsen · 2018-01-24T12:05:42Z

@WilliamHPNielsen I have no clue what the correct way to handle this is in Qcodes. I am just pointing out that the behaviour of the ZNB instrument when setting bandwidth is pretty unintuitive. If you try to set the bandwidth to 120 Hz it will silently round it off to nearest step being 100 Hz.

Ahh, think I missread your comment at first. Using a validator to check if the number is allowed before talking to the instrument sounds good.

WilliamHPNielsen · 2018-01-25T09:35:27Z

@ThorvaldLarsen I see. It is very good that you point this is out. Then the correct way is indeed to make any attempt of setting a value that can not be realised fail using an appropriate validator. We are paranoid about machines silently doing things behind our backs.

WilliamHPNielsen · 2018-01-25T09:36:22Z

@ThorvaldLarsen If you need help writing a custom validator for this case, just ping me.

Dominik-Vogel · 2018-01-30T09:02:27Z

@ThorvaldLarsen, @WilliamHPNielsen I'll add the validator.

…odes into driver/ZnbRefactorSweep

…hannel

jenshnielsen

Left a few very minor comments

jenshnielsen · 2018-02-06T09:35:33Z

qcodes/instrument_drivers/rohde_schwarz/ZNB.py

@@ -42,11 +21,12 @@ def __init__(self, name, instrument, start, stop, npts, channel):
 self._channel = channel
 self.names = ('magnitude',
 'phase')
- self.labels = ('{} magnitude'.format(instrument._vna_parameter),
- '{} phase'.format(instrument._vna_parameter))
+ self.labels = ('{} magnitude'.format(instrument.short_name),


Can you remind me of name, full_name vs short name

full name is 'Instrument name'_'Channel name' and short_name is 'Channel name'.
In my case full name is VNA_S21 for and short_name is S21.

Ok thats cool

jenshnielsen · 2018-02-06T09:36:55Z

qcodes/instrument_drivers/rohde_schwarz/ZNB.py

+ data = self._instrument._get_sweep_data()
+ if self._instrument.format() in ['Polar', 'Complex',
+ 'Smith', 'Inverse Smith']:
+ log.warning("QCoDeS Dataset does not currently support Complex "


Perhaps this warning should point to the other parameter

good point, I'll add it.

jenshnielsen · 2018-02-06T09:39:57Z

qcodes/instrument_drivers/rohde_schwarz/ZNB.py

+ def __init__(self, parent, name, channel, vna_parameter: str=None):
+ """
+ Args:
+ vna_parameter: if left empty name is used


I would write a bit more here.

Args: parent: Instrument that this channel is bound to. name: Name to use for this parameter vna_parameter: Name of parameter on the vna that this should measure such as S11. If left empty this will fall back to `name`

@ThorvaldLarsen could you write this? I think you can find more concise words than me ;-)

Might just want to change a word or two for clarity. But the part that Jens wrote looks pretty good to me.

Args: parent: Instrument that this channel is bound to. name: Name to use for this channel. vna_parameter: Name of parameter on the vna that this should measure such as S12. If left empty this will fall back to `name`.

done. Ready to merge?

Author: Dominik Vogel <[email protected]> Rohde Schwarz ZNB /VNA refactor common code (#887)

3746: Bump types-docutils from 0.17.1 to 0.17.2 r=jenshnielsen a=dependabot[bot] Bumps [types-docutils](https:/python/typeshed) from 0.17.1 to 0.17.2. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https:/python/typeshed/commits">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=types-docutils&package-manager=pip&previous-version=0.17.1&new-version=0.17.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 3747: Bump attrs from 21.2.0 to 21.3.0 r=jenshnielsen a=dependabot[bot] Bumps [attrs](https:/python-attrs/attrs) from 21.2.0 to 21.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https:/python-attrs/attrs/releases">attrs's releases</a>. <blockquote> <h2>21.3.0</h2> This is a big release in the history of <code>attrs</code> and finishes an arc that took way too long and also delayed this very overdue release. But it's done: <code>import attrs</code> that has been talked about for years[^issue], but fell victim to “just this one more thing” has finally landed. From now on, modern <code>attrs</code> code looks like this: <pre lang="python"><code>from attrs import define <a href="https:/define"><code>`@define</code></a>` class HelloWorld: modern: bool = True </code></pre> The <code>define</code>/<code>field</code> APIs have been around for over a year and were very popular, now the rest of the package followed suit. I'm very excited that <code>attrs</code> remains relevant and keeps evolving over now more than half a decade. If you're curious about some of the background, the docs now contain a short <a href="https://www.attrs.org/en/stable/names.html">explanation and history lesson</a>. As long as our users keep pushing us, we will keep pushing forward class generation in Python! Big thanks to my <a href="https:/sponsors/hynek/dashboard">GitHub Sponsors</a>, <a href="https://tidelift.com/subscription/pkg/pypi-attrs?utm_source=pypi-attrs&utm_medium=referral&utm_campaign=enterprise&utm_term=repo">Tidelift subscribers</a>, and <a href="https://ko-fi.com/the_hynekl">Ko-fi buyers</a> that help me mustering the motivation for such long-running project! <hr /> Since the release took so long, there's more highlights than we can enumerate here, we'd just like to point out a breaking change in the new APIs: converters now run on setting attributes by default. If this is causing problems to you, you can disable that behavior by setting <code>`@define(on_setattr=[])</code>.` [^issue]: I have an issue from 2018 that I wanted to "come back the moment this lands". <h1>Full Changelog</h1> <h2>Backward-incompatible Changes</h2> <ul> <li> When using <code>`@define</code>,` converters are now run by default when setting an attribute on an instance -- additionally to validators. I.e. the new default is <code>on_setattr=[attrs.setters.convert, attrs.setters.validate]</code>. This is unfortunately a breaking change, but it was an oversight, impossible to raise a <code>DeprecationWarning</code> about, and it's better to fix it now while the APIs are very fresh with few users. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/835">#835</a>, <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/886">#886</a> </li> <li> <code>import attrs</code> has finally landed! As of this release, you can finally import <code>attrs</code> using its proper name. Not all names from the <code>attr</code> namespace have been transferred; most notably <code>attr.s</code> and <code>attr.ib</code> are missing. See <code>attrs.define</code> and <code>attrs.field</code> if you haven't seen our next-generation APIs yet. A more elaborate explanation can be found <a href="https://www.attrs.org/en/latest/names.html">On The Core API Names</a> This feature is at least for one release provisional. We don't plan on changing anything, but such a big change is unlikely to go perfectly on the first strike. The API docs have been mostly updated, but it will be an ongoing effort to change everything to the new APIs. Please note that we have not moved -- or even removed -- anything from <code>attr</code>! Please do report any bugs or documentation inconsistencies! <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/887">#887</a> </li> </ul> <h2>Changes</h2> <ul> <li><code>attr.asdict(retain_collection_types=False)</code> (default) dumps collection-esque keys as tuples. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/646">#646</a>, <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/888">#888</a></li> <li><code>__match_args__</code> are now generated to support Python 3.10's <a href="https://docs.python.org/3.10/whatsnew/3.10.html#pep-634-structural-pattern-matching">Structural Pattern Matching</a>. This can be controlled by the <code>match_args</code> argument to the class decorators on Python 3.10 and later. On older versions, it is never added and the argument is ignored. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/815">#815</a></li> <li>If the class-level on_setattr is set to <code>attrs.setters.validate</code> (default in <code>`@define</code>` and <code>`@mutable</code>)` but no field defines a validator, pretend that it's not set. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/817">#817</a></li> <li>The generated <code>__repr__</code> is significantly faster on Pythons with f-strings. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/819">#819</a></li> <li>Attributes transformed via <code>field_transformer</code> are wrapped with <code>AttrsClass</code> again. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/824">#824</a></li> <li>Generated source code is now cached more efficiently for identical classes. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/828">#828</a></li> <li>Added <code>attrs.converters.to_bool()</code>. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/830">#830</a></li> </ul>  </blockquote> ... (truncated) </details> <details> <summary>Changelog</summary> Sourced from <a href="https:/python-attrs/attrs/blob/main/CHANGELOG.rst">attrs's changelog</a>. <blockquote> <h2>21.3.0 (2021-12-28)</h2> Backward-incompatible Changes ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li> When using <code>`@define</code>,` converters are now run by default when setting an attribute on an instance -- additionally to validators. I.e. the new default is <code>on_setattr=[attrs.setters.convert, attrs.setters.validate]</code>. This is unfortunately a breaking change, but it was an oversight, impossible to raise a <code>DeprecationWarning</code> about, and it's better to fix it now while the APIs are very fresh with few users. <code>[#835](python-attrs/attrs#835) <https:/python-attrs/attrs/issues/835></code>, <code>[#886](python-attrs/attrs#886) <https:/python-attrs/attrs/issues/886></code> </li> <li> <code>import attrs</code> has finally landed! As of this release, you can finally import <code>attrs</code> using its proper name. Not all names from the <code>attr</code> namespace have been transferred; most notably <code>attr.s</code> and <code>attr.ib</code> are missing. See <code>attrs.define</code> and <code>attrs.field</code> if you haven't seen our next-generation APIs yet. A more elaborate explanation can be found <code>On The Core API Names <https://www.attrs.org/en/latest/names.html></code>_ This feature is at least for one release provisional. We don't plan on changing anything, but such a big change is unlikely to go perfectly on the first strike. The API docs have been mostly updated, but it will be an ongoing effort to change everything to the new APIs. Please note that we have not moved -- or even removed -- anything from <code>attr</code>! Please do report any bugs or documentation inconsistencies! <code>[#887](python-attrs/attrs#887) <https:/python-attrs/attrs/issues/887></code>_ </li> </ul> Changes ^^^^^^^ <ul> <li><code>attr.asdict(retain_collection_types=False)</code> (default) dumps collection-esque keys as tuples. <code>[#646](python-attrs/attrs#646) <https:/python-attrs/attrs/issues/646></code>, <code>[#888](python-attrs/attrs#888) <https:/python-attrs/attrs/issues/888></code></li> <li><code>__match_args__</code> are now generated to support Python 3.10's <code>Structural Pattern Matching <https://docs.python.org/3.10/whatsnew/3.10.html#pep-634-structural-pattern-matching></code>. This can be controlled by the <code>match_args</code> argument to the class decorators on Python 3.10 and later. On older versions, it is never added and the argument is ignored. <code>[#815](python-attrs/attrs#815) <https:/python-attrs/attrs/issues/815></code></li> <li>If the class-level on_setattr is set to <code>attrs.setters.validate</code> (default in <code>`@define</code>` and <code>`@mutable</code>)` but no field defines a validator, pretend that it's not set. <code>[#817](python-attrs/attrs#817) <https:/python-attrs/attrs/issues/817></code>_</li> <li>The generated <code>__repr__</code> is significantly faster on Pythons with f-strings. <code>[#819](python-attrs/attrs#819) <https:/python-attrs/attrs/issues/819></code>_</li> <li>Attributes transformed via <code>field_transformer</code> are wrapped with <code>AttrsClass</code> again. <code>[#824](python-attrs/attrs#824) <https:/python-attrs/attrs/issues/824></code>_</li> <li>Generated source code is now cached more efficiently for identical classes. <code>[#828](python-attrs/attrs#828) <https:/python-attrs/attrs/issues/828></code>_</li> <li>Added <code>attrs.converters.to_bool()</code>. <code>[#830](python-attrs/attrs#830) <https:/python-attrs/attrs/issues/830></code>_</li> </ul>  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https:/python-attrs/attrs/commit/dd26edd68e12879f716c6554f25d957af299b801"><code>dd26edd</code></a> Prepare 21.3.0</li> <li><a href="https:/python-attrs/attrs/commit/20bf4b6e54a75201b378cff8e6dd9521d2da28f1"><code>20bf4b6</code></a> Go over CONTRIBUTING.md</li> <li><a href="https:/python-attrs/attrs/commit/d528dd425980eff3f43b0e29b0ce4dc81ecd8d84"><code>d528dd4</code></a> Fix more links</li> <li><a href="https:/python-attrs/attrs/commit/fcfb5a692cc8c9f8fde8e39bbd2c5733a47fb1e7"><code>fcfb5a6</code></a> Last pass over changelogs</li> <li><a href="https:/python-attrs/attrs/commit/e09873485e14e9b11d5d590a55280894df367d92"><code>e098734</code></a> Add logo to PyPI description</li> <li><a href="https:/python-attrs/attrs/commit/26c0cef8e48bd131d062d45bdaa0c949d4a2d035"><code>26c0cef</code></a> Streamline workflow</li> <li><a href="https:/python-attrs/attrs/commit/3333e749781a107c829717f7bc0382d33b538b6e"><code>3333e74</code></a> Remove dead achor</li> <li><a href="https:/python-attrs/attrs/commit/2d77d83d4e3ceadbf4414da5963623a20564c415"><code>2d77d83</code></a> Fix dataclass_transform links</li> <li><a href="https:/python-attrs/attrs/commit/b4dc9b07c70c16848960da077fc7ac18fe5e9bc8"><code>b4dc9b0</code></a> Better 2.7 example</li> <li><a href="https:/python-attrs/attrs/commit/d4e32209dc5855796e57c2b08bdc1c1702d051ab"><code>d4e3220</code></a> Use attrs namespace throughout examples.rst</li> <li>Additional commits viewable in <a href="https:/python-attrs/attrs/compare/21.2.0...21.3.0">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=attrs&package-manager=pip&previous-version=21.2.0&new-version=21.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Dominik-Vogel added 3 commits November 28, 2017 17:00

added try/finally for data aquisition

283540c

extracted into method of channel

b956c18

implementing FrequencySweepMagPhase through refactored method in channel

043ad25

fixed typo: argument list

c499932

Dominik-Vogel added 3 commits December 6, 2017 15:09

added CHANNEL_CLASS class variable for inheritance

2fb0c96

activate the sweep for selected channel and restore previous state

92e0153

renamig get->get_raw

2f8b998

Dominik-Vogel mentioned this pull request Dec 6, 2017

Custom VNA qdev-dk/qdev-wrappers#32

Merged

3 tasks

refactored update of traces out

3dd4d22

nataliejpg and others added 7 commits December 15, 2017 11:21

T2 vna fixes

b940ae0

fix of iteration over parameters

254223c

thorvalds fix for averaging data

a874c04

fix validator for minimum source power to -60dBm

ec82000

default to 7 decimals

09bb252

dual window mode

3fc12c3

Thorvald: removed blank line from setpoints

3e26d60

ThorvaldLarsen reviewed Jan 22, 2018

View reviewed changes

Dominik-Vogel added 5 commits January 23, 2018 10:22

remove blank line from setpoint names

11201e9

Thorvald: fixing the channel initialisation

9e556f6

remove initialise and default values

9e4e38d

setting validator for minimum source power to model specific value

eff2dd8

get parser for source power to float

7363f24

ThorvaldLarsen reviewed Jan 23, 2018

View reviewed changes

Dominik-Vogel added 3 commits January 23, 2018 14:22

added channels as submodules

6aab338

_instrument->_parent

d30802e

using setattr for shortcut instead of add_submodule

fac84d0

jenshnielsen and others added 5 commits January 30, 2018 10:33

Merge branch 'master' into driver/ZnbRefactorSweep

474d84a

added validator for Bandwidth

90effe5

Merge branch 'driver/ZnbRefactorSweep' of github.com:Dominik-Vogel/Qc…

33e7b8a

…odes into driver/ZnbRefactorSweep

added optional van parameter

2fce66d

added short name to differentiate between vna_parameter and name of c…

5c881c0

…hannel

Dominik-Vogel requested a review from jenshnielsen February 6, 2018 09:33

jenshnielsen reviewed Feb 6, 2018

View reviewed changes

Dominik-Vogel and others added 3 commits February 6, 2018 15:01

updated warning

5ed254a

updated comment for InstrumentChannel init

c98baca

Merge branch 'master' into driver/ZnbRefactorSweep

e9a5d95

jenshnielsen approved these changes Feb 7, 2018

View reviewed changes

jenshnielsen merged commit e4986ac into microsoft:master Feb 7, 2018

giulioungaretti pushed a commit that referenced this pull request Feb 7, 2018

Generated gh-pages for commit e4986ac

eb5221b

Author: Dominik Vogel <[email protected]> Rohde Schwarz ZNB /VNA refactor common code (#887)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rohde Schwarz ZNB /VNA refactor common code #887

Rohde Schwarz ZNB /VNA refactor common code #887

Dominik-Vogel commented Nov 28, 2017 •

edited

Loading

Dominik-Vogel commented Nov 28, 2017

Dominik-Vogel commented Nov 28, 2017

jenshnielsen commented Nov 30, 2017 •

edited

Loading

jenshnielsen commented Nov 30, 2017

Dominik-Vogel commented Dec 6, 2017

ThorvaldLarsen commented Dec 6, 2017

codecov bot commented Dec 15, 2017 •

edited

Loading

ThorvaldLarsen Jan 22, 2018 •

edited

Loading

ThorvaldLarsen Jan 23, 2018

Dominik-Vogel Jan 23, 2018

ThorvaldLarsen commented Jan 24, 2018

WilliamHPNielsen commented Jan 24, 2018

ThorvaldLarsen commented Jan 24, 2018 •

edited

Loading

WilliamHPNielsen commented Jan 25, 2018

WilliamHPNielsen commented Jan 25, 2018

Dominik-Vogel commented Jan 30, 2018

jenshnielsen left a comment

jenshnielsen Feb 6, 2018

ThorvaldLarsen Feb 6, 2018

jenshnielsen Feb 6, 2018

jenshnielsen Feb 6, 2018

Dominik-Vogel Feb 6, 2018 •

edited

Loading

jenshnielsen Feb 6, 2018

Dominik-Vogel Feb 6, 2018

ThorvaldLarsen Feb 6, 2018 •

edited

Loading

Dominik-Vogel Feb 7, 2018

Rohde Schwarz ZNB /VNA refactor common code #887

Rohde Schwarz ZNB /VNA refactor common code #887

Conversation

Dominik-Vogel commented Nov 28, 2017 • edited Loading

Dominik-Vogel commented Nov 28, 2017

Dominik-Vogel commented Nov 28, 2017

jenshnielsen commented Nov 30, 2017 • edited Loading

jenshnielsen commented Nov 30, 2017

Dominik-Vogel commented Dec 6, 2017

ThorvaldLarsen commented Dec 6, 2017

codecov bot commented Dec 15, 2017 • edited Loading

Codecov Report

ThorvaldLarsen Jan 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThorvaldLarsen commented Jan 24, 2018

WilliamHPNielsen commented Jan 24, 2018

ThorvaldLarsen commented Jan 24, 2018 • edited Loading

WilliamHPNielsen commented Jan 25, 2018

WilliamHPNielsen commented Jan 25, 2018

Dominik-Vogel commented Jan 30, 2018

jenshnielsen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dominik-Vogel Feb 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThorvaldLarsen Feb 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dominik-Vogel commented Nov 28, 2017 •

edited

Loading

jenshnielsen commented Nov 30, 2017 •

edited

Loading

codecov bot commented Dec 15, 2017 •

edited

Loading

ThorvaldLarsen Jan 22, 2018 •

edited

Loading

ThorvaldLarsen commented Jan 24, 2018 •

edited

Loading

Dominik-Vogel Feb 6, 2018 •

edited

Loading

ThorvaldLarsen Feb 6, 2018 •

edited

Loading