Add atomic& operator=(const atomic&) volatile = delete;

microsoft · Dec 24, 2023 · 59b7141 · 59b7141
1 parent a888880
commit 59b7141
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/stl/inc/atomic b/stl/inc/atomic
@@ -2155,8 +2155,9 @@ public:
 
  constexpr atomic() noexcept(is_nothrow_default_constructible_v<_Ty>) : _Base() {}
 
- atomic(const atomic&) = delete;
- atomic& operator=(const atomic&) = delete;
+ atomic(const atomic&) = delete;
+ atomic& operator=(const atomic&) = delete;
+ atomic& operator=(const atomic&) volatile = delete;
 
 #if _HAS_CXX17
  static constexpr bool is_always_lock_free = _Is_always_lock_free<sizeof(_Ty)>;

diff --git a/tests/libcxx/expected_results.txt b/tests/libcxx/expected_results.txt
@@ -1227,10 +1227,6 @@ std/ranges/range.adaptors/range.split/general.pass.cpp:1 FAIL
 std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/compare.pass.cpp:0 FAIL
 std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/compare.pass.cpp:1 FAIL
 
-# Not analyzed. static_assert failed: '!std::is_assignable_v<volatile std::atomic<T>&, const std::atomic<T>&>'
-# The Standard depicts `atomic& operator=(const atomic&) volatile = delete;` which we seem to be missing.
-std/atomics/atomics.types.generic/atomics.types.float/copy.compile.pass.cpp FAIL
-
 # Not analyzed.
 # MSVC error C2087: 'abstract declarator': missing subscript
 # Clang error: array has incomplete element type 'int[]'