Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update working draft revision to N4917 #3094

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Sep 8, 2022

https://wg21.link/n4917 is not working currently but probably will be updated before this PR will be merged.

github release: https:/cplusplus/draft/releases/download/n4917/n4917.pdf

@fsb4000 fsb4000 requested a review from a team as a code owner September 8, 2022 17:19
@AlexGuteniev
Copy link
Contributor

The link works fine for me

@frederick-vs-ja
Copy link
Contributor

How about consistently updating the references to working drafts in comments/static_assert messages? I've updated the referenced number to N4910 in <xstring> and <cmath>, but not in other headers.

(It's weird that even change to README.md requires running tests...)

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Sep 8, 2022
@StephanTLavavej
Copy link
Member

@frederick-vs-ja

How about consistently updating the references to working drafts in comments/static_assert messages?

That's tracked by #182. It can't be automated (since we have to look out for paragraph numbers changing and wording being moved), but if you'd like to prepare a PR, go ahead! I'd say that it can be done incrementally (no need to update the entire codebase all at once; individual files already cite a mix of WP numbers so I don't even think intra-file consistency is necessary, although of course it's nice). I'd also say that the static_assert messages which are displayed to users are somewhat higher priority than code comments.

(It's weird that even change to README.md requires running tests...)

We need to run Code Format Validation to detect disallowed characters etc. It would be possible to configure Azure Pipelines to skip the build and test stages for readme changes - I see how to do it, but it would take some time, and README-only updates haven't been that frequent.

@fsb4000
Copy link
Contributor Author

fsb4000 commented Sep 9, 2022

Yes, https://wg21.link/n4917 works for me via proxy but not directly.
Probably it's my ISP's problem, not that site's.

@StephanTLavavej StephanTLavavej self-assigned this Sep 12, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6c0c9a9 into microsoft:main Sep 13, 2022
@StephanTLavavej
Copy link
Member

Thanks for updating the WP link! ⛓️ ✅ 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants