Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [[msvc::intrinsic]] for some cast funcs. #3664

Merged
merged 4 commits into from
Jul 20, 2023
Merged

add [[msvc::intrinsic]] for some cast funcs. #3664

merged 4 commits into from
Jul 20, 2023

Conversation

infdahai
Copy link
Contributor

@infdahai infdahai commented Apr 19, 2023 •
edited
Loading

  1. use the macro _MSVC_INTRINSIC to add some cast functions' headers.
  2. Fixes STL: Mark simple casting free functions with _MSVC_INTRINSIC #3548

@infdahai infdahai requested a review from a team as a code owner April 19, 2023 12:38
@infdahai
Copy link
Contributor Author

@microsoft-github-policy-service agree

@fsb4000

This comment was marked as resolved.

Sign in to view
@fsb4000

This comment was marked as resolved.

Sign in to view
@infdahai

This comment was marked as resolved.

Sign in to view
@infdahai infdahai changed the title add [[msvc::intrinsic]] for some cast func. add [[msvc::intrinsic]] for some cast funcs. Apr 19, 2023
@StephanTLavavej StephanTLavavej added the performance Must go faster label Apr 19, 2023
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label Apr 19, 2023
@cdacamar

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@fsb4000

This comment was marked as resolved.

Sign in to view
@frederick-vs-ja

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@WhiteSmoogy

This comment was marked as resolved.

Sign in to view
@fsb4000

This comment was marked as resolved.

Sign in to view
@infdahai

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Jul 14, 2023
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@frederick-vs-ja

This comment was marked as resolved.

Sign in to view
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jul 20, 2023 •
edited by CaseyCarter
Loading

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter removed their assignment Jul 20, 2023
@StephanTLavavej StephanTLavavej merged commit ef8baca into microsoft:main Jul 20, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for improving this codegen and congratulations on your first microsoft/STL commit! 🎉 🚀 😻

@infdahai infdahai deleted the simp_intric_support branch January 3, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STL: Mark simple casting free functions with _MSVC_INTRINSIC
7 participants
@infdahai @fsb4000 @StephanTLavavej @cdacamar @frederick-vs-ja @WhiteSmoogy @CaseyCarter