Fix hh_mm_ss
formatting for values >= 1 day
#3727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
hh_mm_ss
s >= 1 dayhh_mm_ss
' formatting implementation to use the hours and minutes explicitly (put_time
does not deal with hours >= 24, which is desired behavior)_Hh_mm_ss_part_underflow_to_zero
and instead cast everyduration
to be formatted this way tohh_mm_ss
directly (this is theformat("{:%T}", some_duration) == "00:00:00"
bug discussed in the original issue (not the same bug, but closely related ;))abs
forduration
s slightly.%H
format override.Fixes #3676