Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make to_array ADL-proof #4042

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Towards #140. I guess we don't need to _STD-qualify other _Ugly names in <array>.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner September 21, 2023 17:45
stl/inc/array Show resolved Hide resolved
@CaseyCarter CaseyCarter added the bug Something isn't working label Sep 21, 2023
But I don't think this can make any program additionally accepted.
@StephanTLavavej
Copy link
Member

I pushed a conflict-free merge with main followed by a workaround for the /clr bug with incomplete types.

@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit bb86444 into microsoft:main Sep 22, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

🐞 🛡️ 🎉

@frederick-vs-ja frederick-vs-ja deleted the adl-proof-to_array branch September 23, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants