Skip libc++'s non-Standard ascii tests, reported upstream
#4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
requested changes
Jan 18, 2024
StephanTLavavej
approved these changes
Jan 19, 2024
StephanTLavavej
changed the title
ascii tests to "LIKELY BOGUS TESTS"ascii tests, reported upstream
CaseyCarter
approved these changes
Jan 19, 2024
StephanTLavavej
added a commit
to llvm/llvm-project
that referenced
this pull request
Jan 20, 2024
…xx` (#78661) As @cpplearner explained in microsoft/STL#4328: > libc++'s "ascii" mode (controlled by the `_LIBCPP_HAS_NO_UNICODE` > macro) means "every code unit outside ASCII is treated as a valid > printable character". AFAIK we \[MSVC's STL\] don't support such a mode. Because these files are testing a non-Standard mode, they should be moved from `libcxx/test/std` to `libcxx/test/libcxx`.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for investigating what was happening here! 🕵️ 💡 😻 |
blueboxd
pushed a commit
to blueboxd/libcxx
that referenced
this pull request
Feb 7, 2024
…xx` (#78661) As @cpplearner explained in microsoft/STL#4328: > libc++'s "ascii" mode (controlled by the `_LIBCPP_HAS_NO_UNICODE` > macro) means "every code unit outside ASCII is treated as a valid > printable character". AFAIK we \[MSVC's STL\] don't support such a mode. Because these files are testing a non-Standard mode, they should be moved from `libcxx/test/std` to `libcxx/test/libcxx`. NOKEYCHECK=True GitOrigin-RevId: 123ab34abc68e2e64720f9690aed5cb9e62a035d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libc++'s "ascii" mode (controlled by the
_LIBCPP_HAS_NO_UNICODEmacro) means "every code unit outside ASCII is treated as a valid printable character". AFAIK we don't support such a mode.For
char, MSVC STL uses the code page specified by_MSVC_EXECUTION_CHARACTER_SET. Some code pages might consider most code units printable, but even Windows-1252 has a couple of non-printable characters.For
wchar_t, we don't have a way to opt-out UTF-16, and I don't see a need to do so.