Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warnings for the benchmarks, and fix them #4356

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Enable warnings for the benchmarks, and fix them #4356

merged 4 commits into from
Feb 1, 2024

Commits on Jan 31, 2024

  1. Enable warnings when building the benchmarks. 

    * Start with the usual: `/diagnostics:caret /W4 /WX`

* I'm enabling the same off-by-default warnings as the STL's build
  (C4265 (non-virtual dtor), C5038 (data member init order))
  and adding C5262 (implicit fallthrough).

* Finally, let's add `/utf-8` in case we ever benchmark `<format>`.
    @StephanTLavavej
    StephanTLavavej committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0fc6029 View commit details
    Browse the repository at this point in the history

  2. Fix x86 size_t truncation warnings in the vector.bool benchmarks.

    @StephanTLavavej
    StephanTLavavej committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    1893a56 View commit details
    Browse the repository at this point in the history

  3. udt.hpp: Rename template parameters from Contained to Data, avoiding … 

    …REALLY confusing diagnostics.
    @StephanTLavavej
    StephanTLavavej committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    45e50c8 View commit details
    Browse the repository at this point in the history

  4. utility.hpp: Silence truncation warnings with a big comment.

    @StephanTLavavej
    StephanTLavavej committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7be8213 View commit details
    Browse the repository at this point in the history