<vector>: More scope guards
#4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
vector-scope-guards
branch
2 times, most recently
from
3a167a2
to
dbd409f
Compare
There're still two occurrences of try-catch-reraise in `_Insert_counted_range`, which don't seem able to be replaced by scope guards if we want to keep the current behavior. It seems that no more `_RERAISE;` in other headers can be replaced with scope guards. Drive-by: strengthening exception specification for - `allocator<T>::deallocate`, - `allocator_traits<allocator<T>>::deallocate`, and - `vector<T, A>::_Change_array`.
frederick-vs-ja
force-pushed
the
vector-scope-guards
branch
from
dbd409f
to
2f45105
Compare
StephanTLavavej
approved these changes
Oct 3, 2024
|
Thanks, this is a very clean transformation! 🪄 I pushed a conflict-free merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks again for improving the STL's bestest data structure! 💯 ⭐ 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2307. Possibly closes it?
There're still two occurrences of try-catch-reraise in
_Insert_counted_range, which don't seem able to be replaced by scope guards if we want to keep the current behavior. It seems that no more_RERAISE;in other headers can be replaced with scope guards.Drive-by: strengthening exception specification for
allocator<T>::deallocate,allocator_traits<allocator<T>>::deallocate, andvector<T, A>::_Change_array.