Skip to content

Commit

Permalink
temp
Browse files Browse the repository at this point in the history
  • Loading branch information
sheetalkamat committed Dec 1, 2023
1 parent 73e6924 commit 939f761
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/compiler/resolutionCache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,9 @@ export function createResolutionCache(
}

function getValidResolution<T extends ResolutionWithFailedLookupLocations>(resolution: T | undefined) {
// TODO: (sheetal) this isnt correct because after the new resolution is calculated and its still unresolved with globalCachePass:
// it will mark new resolution as invalidated as well
// (unresolvedResolutionsWithGlobalCachePassAreInvalidated && resolution.globalCacheResolution && isUnresolvedOrResolvedToJs(resolution as ResolvedModuleWithFailedLookupLocations));
return isInvalidatedResolution(resolution) ? undefined : resolution;
}

Expand Down Expand Up @@ -1395,6 +1398,8 @@ export function createResolutionCache(

// filePath is for the projectReference and the containing file is from this project reference, invalidate the resolution
resolvedProjectReference.commandLine.fileNames.forEach(f => removeResolutionsOfFile(resolutionHost.toPath(f)));

// TODO: (sheetal) this is not correct as we would want to instead update to re-evaluate redirected-references
}

function removeResolutionsOfFile(filePath: Path, syncDirWatcherRemove?: boolean) {
Expand Down

0 comments on commit 939f761

Please sign in to comment.