Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit access member for decorators #52540

Closed
DanielRosenwasser opened this issue Jan 31, 2023 · 0 comments · Fixed by #52582
Closed

Revisit access member for decorators #52540

DanielRosenwasser opened this issue Jan 31, 2023 · 0 comments · Fixed by #52582
Assignees
@rbuckton
Labels
Domain: Decorators The issue relates to the decorator syntax Fix Available A PR has been opened for this issue Waiting for TC39 Unactionable until TC39 reaches some conclusion
Milestone
TypeScript 5.0.1

Comments

@DanielRosenwasser
Copy link
Member

We're providing feedback around the access member of decorator context objects. The formal issue is over at tc39/proposal-decorators#494, but we have a few possible outcomes.

If access is amended to have some new API, we should change the API to agree with whatever specified. When that happens, we should consider whether it should be declared with function shorthand syntax to avoid method parameter bivariance issues.

If we can't agree on something, we might need to place a variance annotation on the type parameters just to afford ourselves with some future design space.
@DanielRosenwasser DanielRosenwasser added Domain: Decorators The issue relates to the decorator syntax Waiting for TC39 Unactionable until TC39 reaches some conclusion labels Jan 31, 2023
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.0.1 milestone Jan 31, 2023
@DanielRosenwasser DanielRosenwasser mentioned this issue Feb 1, 2023
Merged
@rbuckton rbuckton mentioned this issue Feb 2, 2023
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbuckton rbuckton

Labels
Domain: Decorators The issue relates to the decorator syntax Fix Available A PR has been opened for this issue Waiting for TC39 Unactionable until TC39 reaches some conclusion
Projects
None yet
Milestone
TypeScript 5.0.1
Development

Successfully merging a pull request may close this issue.

Decorators normative changes microsoft/TypeScript
3 participants
@DanielRosenwasser @rbuckton @typescript-bot