-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Meeting Notes, 11/1/2023 #56359
Labels
Design Notes
Notes from our design meetings
Comments
@justinfagnani looks like there may be some progress here on native CSS imports but they are looking for some additional context from your experience. |
6 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parentheses Changes Result of Conditional Type
#56270
#56271
extends
clause in a conditional type, it changes distributivity.[]
to avoid distributivity.[]
, but parentheses were affected.Ambient module declarations for import assertions
#46135
Browsers have either shipped or indicate positive support for this feature.
What is it? Basically want to be able to import assets like
css
files and bring them in as default imports in the form ofCSSStyleSheet
objects.How do you convince TypeScript of this?
Maybe something like:
How does this work with merging? Multiple declarations? Fallbacks?
Maybe there needs to be a lookup strategy.
In other words, do
and
both resolve to the following declaration?
Why can't you get away with just always using a
*.css
pattern?Stepping back, pattern ambient modules really mask over everything. Kind of heavy-handed. You do want TypeScript to resolve the
.css
file on disk and validate that it's there, right? Usually?Want to express "what is my bundler going to do here?", and sometimes it is not best-served by what's in an ambient module, but rather what's on disk.
.d.css.ts
files under some settings.What about something like
*.css
imports, but does provide a well-understood shape.Doesn't this need a special resolution mode?
How does this affect emit?
.json
files..css
files from source?.d.css.ts
generation?How do
.json
imports work at all today?Wait, we do copy JSON to outputs?
outDir
.We do want a bit more context on how this should work in a larger project.
Conclusions?
Revisit real resolution/emit for certain file types, plus import attribute-y ambient modules
Want to understand the full breadth of motivations
The text was updated successfully, but these errors were encountered: