build: add check for lib size #24712
Conversation
|
|
scripts/build/get-dir-size.js
Outdated
| const { lstatSync, readdirSync } = require("fs"); | ||
| const { join } = require("path"); | ||
| const { promisify } = require("util"); | ||
| const execFile = promisify(require("child_process").execFile); |
There was a problem hiding this comment.
I don't know if is needed, but promisify not exists in node 6.
There was a problem hiding this comment.
Also, execFile isn't used?
There was a problem hiding this comment.
Oops, this was a bad copypasta on my part 😟
I removed it 🔧
Gulpfile.js
Outdated
| @@ -12,6 +12,7 @@ const clone = require("gulp-clone"); | |||
| const newer = require("gulp-newer"); | |||
| const tsc = require("gulp-typescript"); | |||
| const tsc_oop = require("./scripts/build/gulp-typescript-oop"); | |||
| const { getDirSize } = require("./scripts/build/get-dir-size"); | |||
There was a problem hiding this comment.
nit, do not use kebab-case, instead use camel case.
|
we also need to make a similar change to jakefile.js |
Gulpfile.js
Outdated
| const seq = runSequence("LKGInternal", "VerifyLKG"); | ||
| const sizeAfter = getDirSize(lib); | ||
| if (sizeAfter > (sizeBefore * 1.10)) { | ||
| throw new Error("The lib folder increased by 10% or more. This likely indicates a bug."); |
There was a problem hiding this comment.
How do we want to confirm "no, this really is what we meant to do"?
There was a problem hiding this comment.
u can manually check in the LKG. this happens after the LKG has been built and updated.
|
@mhegazy Which line number in the https:/Microsoft/TypeScript/blob/8b77b13166df82f32d1edbc121ba42c46006a3a0/Jakefile.js#L657-L660 |
|
I would do it after we have copied all expected files. |
|
@mhegazy How does that look? |
|
thanks! |
This adds a check to make sure the lib size doesn't increase more than 10% after the "LKG" step.
This change was suggested by mhegazy in this comment.
Related #24282