Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick PR #54450 into release-5.0: Resolve tslib re-exports before checking arity #54462

Closed
wants to merge 1 commit into from

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented May 30, 2023

PR #54450

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 30, 2023
@andrewbranch
Copy link
Member Author

Related: #54328 (will probably conflict since change overlaps)

@jakebailey
Copy link
Member

I need to go fix up the browser integration test to do things a little differently; right now it npm installs a new package and that means that we get unexpected versions of other deps on old release branches like this one, which as you've seen can cause problems.

@sandersn
Copy link
Member

@andrewbranch Is this still needed?

@andrewbranch
Copy link
Member Author

It would be nice but it’s up to @DanielRosenwasser if he wants to do an older patch for this.

@andrewbranch andrewbranch deleted the pick-54450 branch September 26, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants