Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled ccache and artifact suffixes for fast-track PR check #8503

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Enabled ccache and artifact suffixes for fast-track PR check #8503

merged 10 commits into from
Mar 25, 2024

Conversation

PawelWMS
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

The ccache should significantly shorten package build times.

The artifact suffix will prevent artifact upload failures during job re-runs as each run will generate an artifact with a different name.

Does this affect the toolchain?

No.

Test Methodology
  • PR check run.

@PawelWMS PawelWMS requested a review from a team as a code owner March 21, 2024 20:39
@PawelWMS PawelWMS changed the title Enabled ccached and artifact suffices for fast-track PR check Enabled ccache and artifact suffixes for fast-track PR check Mar 21, 2024
sameluch
sameluch approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@sameluch sameluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Do you have a test run of these changes handy somewhere?

@PawelWMS
Copy link
Contributor Author

Looks Good! Do you have a test run of these changes handy somewhere?

I used to - it's the PR check for this PR. It's possible the build has already been cleaned-up but you can still see all PR checks passing.

anphel31
anphel31 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@anphel31 anphel31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the PR check run here. Looks good

@PawelWMS PawelWMS merged commit 4e5ef95 into fasttrack/2.0 Mar 25, 2024
22 checks passed
@PawelWMS PawelWMS deleted the pawelwi/ccache_pr_check branch March 25, 2024 23:15
CBL-Mariner-Bot pushed a commit that referenced this pull request Mar 25, 2024
@PawelWMS @CBL-Mariner-Bot
Enabled ccache and artifact suffixes for fast-track PR check (#8503)
7154949 
(cherry picked from commit 4e5ef95)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Mar 25, 2024
Merged
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=535573&view=results

@PawelWMS PawelWMS added the Tools label May 15, 2024
PawelWMS added a commit that referenced this pull request Sep 9, 2024
@PawelWMS
Enabled ccache and artifact suffixes for fast-track PR check (#8503)
7b9ff2d
@PawelWMS PawelWMS mentioned this pull request Sep 9, 2024
Merged
12 tasks
PawelWMS added a commit that referenced this pull request Sep 9, 2024
@PawelWMS
Enabled ccache and artifact suffixes for fast-track PR check (#8503)
cf16a88
PawelWMS added a commit that referenced this pull request Sep 9, 2024
@PawelWMS
Enabled ccache and set ptest retries to 1 for PR checks (CP: #8503, #…
f97819a 
…10133) (#10392)
CBL-Mariner-Bot pushed a commit that referenced this pull request Sep 9, 2024
@PawelWMS @CBL-Mariner-Bot
Enabled ccache and set ptest retries to 1 for PR checks (CP: #8503, #…
d38570c 
…10133) (#10392)

(cherry picked from commit f97819a)
PawelWMS added a commit that referenced this pull request Sep 12, 2024
@CBL-Mariner-Bot @PawelWMS
[AUTO-CHERRYPICK] Enabled ccache and set ptest retries to 1 for PR ch…
947344e 
…ecks (CP: #8503, #10133) - branch 3.0-dev (#10393)

Co-authored-by: Pawel Winogrodzki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anphel31 anphel31 anphel31 approved these changes

@sameluch sameluch sameluch approved these changes

Assignees
No one assigned
Labels
Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PawelWMS @CBL-Mariner-Bot @anphel31 @sameluch