Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors returned from a skill call have an incorrect 'content type' of text/plain #1385

Open
EricDahlvang opened this issue Sep 15, 2020 · 2 comments
Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete

Comments

@EricDahlvang
Copy link
Member

Version

latest

Describe the bug

If an exception occurs when a skill calls the skill host, the content type header is text/plain when it should be application/json

Screenshots

If applicable, add screenshots to help explain your problem.
image

Additional context

This results in 'Cannot deserialize content-type: text/plain'', and it is extremely difficult to determine the actual underlying error.

@EricDahlvang EricDahlvang added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Sep 15, 2020
@tracyboehrer
Copy link
Member

@EricDahlvang I've seen text before when the response isn't json... as in an error, bad request, etc... The result code of this is 401. Could that be related?

@tracyboehrer tracyboehrer added Area: Skills The issue is related to skills and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Nov 3, 2020
@gabog gabog added this to the R12 milestone Nov 16, 2020
@gabog gabog added P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete labels Nov 16, 2020
@anushkrishnav
Copy link

I would love to work on this !!

@tracyboehrer tracyboehrer modified the milestones: R12, r13 Feb 1, 2021
@axelsrz axelsrz modified the milestones: R13, R14 Apr 14, 2021
@tracyboehrer tracyboehrer removed this from the R14 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Development

No branches or pull requests

5 participants