fix: typo in OnMEBotMessagePreviewSend (#1212)

microsoft · Jul 12, 2021 · 782eb6e · 782eb6e
1 parent e2b2570
commit 782eb6e
Show file tree

Hide file tree

Showing 5 changed files with 51 additions and 69 deletions.
diff --git a/packages/Teams/js/src/adaptiveTeamsBotComponent.ts b/packages/Teams/js/src/adaptiveTeamsBotComponent.ts
@@ -48,7 +48,6 @@ import {
  OnTeamsMECardButtonClicked,
  OnTeamsMEConfigQuerySettingUrl,
  OnTeamsMEConfigSetting,
- OnTeamsMEConfigurationSetting,
  OnTeamsMEFetchTask,
  OnTeamsMEQuery,
  OnTeamsMESelectItem,
@@ -185,10 +184,6 @@ export class AdaptiveTeamsBotComponent extends BotComponent {
  { kind: OnTeamsMEFetchTask.$kind, type: OnTeamsMEFetchTask },
  { kind: OnTeamsMEQuery.$kind, type: OnTeamsMEQuery },
  { kind: OnTeamsMESelectItem.$kind, type: OnTeamsMESelectItem },
- {
- kind: OnTeamsMEConfigurationSetting.$kind,
- type: OnTeamsMEConfigurationSetting,
- },
  {
  kind: OnTeamsMESubmitAction.$kind,
  type: OnTeamsMESubmitAction,

diff --git a/packages/Teams/js/src/conditions/onTeamsMEBotMessagePreviewSend.ts b/packages/Teams/js/src/conditions/onTeamsMEBotMessagePreviewSend.ts
@@ -11,7 +11,7 @@ import { OnInvokeActivity } from 'botbuilder-dialogs-adaptive';
  * and activity.value.botMessagePreviewAction == 'send'.
  */
 export class OnTeamsMEBotMessagePreviewSend extends OnInvokeActivity {
- static $kind = 'Teams.OnMEBotMessagePreviewEdit';
+ static $kind = 'Teams.OnMEBotMessagePreviewSend';
 
  public commandId?: string;
 

diff --git a/packages/Teams/js/src/conditions/onTeamsMEConfigurationSetting.ts b/packages/Teams/js/src/conditions/onTeamsMEConfigurationSetting.ts
diff --git a/...packages/Microsoft.Bot.Components.Teams.Tests/Microsoft.Bot.Components.Teams.Tests.csproj b/...packages/Microsoft.Bot.Components.Teams.Tests/Microsoft.Bot.Components.Teams.Tests.csproj
diff --git a/...es/Teams/Shared Tests/ConditionalTests/ConditionalsTests_OnTeamsActivityTypes.test.dialog b/...es/Teams/Shared Tests/ConditionalTests/ConditionalsTests_OnTeamsActivityTypes.test.dialog
@@ -93,6 +93,26 @@
  }
  ]
  },
+ {
+ "$kind": "Teams.OnMEBotMessagePreviewEdit",
+ "condition": "turn.activity.text == 'OnMEBotMessagePreviewEdit'",
+ "actions": [
+ {
+ "$kind": "Microsoft.SendActivity",
+ "activity": "OnMEBotMessagePreviewEdit"
+ }
+ ]
+ },
+ {
+ "$kind": "Teams.OnMEBotMessagePreviewSend",
+ "condition": "turn.activity.text == 'OnMEBotMessagePreviewSend'",
+ "actions": [
+ {
+ "$kind": "Microsoft.SendActivity",
+ "activity": "OnMEBotMessagePreviewSend"
+ }
+ ]
+ },
  {
  "$kind": "Teams.OnMECardButtonClicked",
  "condition": "turn.activity.text == 'OnCardButtonClicked'",
@@ -372,6 +392,36 @@
  "$kind": "Microsoft.Test.AssertReply",
  "text": "OnFileConsent"
  },
+ {
+ "$kind": "Microsoft.Test.UserActivity",
+ "activity": {
+ "type": "invoke",
+ "text": "OnMEBotMessagePreviewEdit",
+ "value": {
+ "botMessagePreviewAction": "edit"
+ },
+ "name": "composeExtension/submitAction"
+ }
+ },
+ {
+ "$kind": "Microsoft.Test.AssertReply",
+ "text": "OnMEBotMessagePreviewEdit"
+ },
+ {
+ "$kind": "Microsoft.Test.UserActivity",
+ "activity": {
+ "type": "invoke",
+ "text": "OnMEBotMessagePreviewSend",
+ "value": {
+ "botMessagePreviewAction": "send"
+ },
+ "name": "composeExtension/submitAction"
+ }
+ },
+ {
+ "$kind": "Microsoft.Test.AssertReply",
+ "text": "OnMEBotMessagePreviewSend"
+ },
  {
  "$kind": "Microsoft.Test.UserActivity",
  "activity": {