Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG Icons don't load in Teams. Affects Core Assistant and Enterprise Assistant #1099

Closed
lauren-mills opened this issue May 11, 2021 · 1 comment · Fixed by #1100
Closed

SVG Icons don't load in Teams. Affects Core Assistant and Enterprise Assistant #1099

lauren-mills opened this issue May 11, 2021 · 1 comment · Fixed by #1100
Assignees
@lauren-mills
Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release
Milestone
R13

Comments

@lauren-mills
Copy link
Contributor

There are some SVG icons in the Core Assistant/Enterprise Assistant that do not load in Teams. Since Teams is one of our primary channels, we should switch these to PNGs.

image

image
@lauren-mills lauren-mills added P0 Must Fix. Release-blocker needs-triage The issue has just been created and it has not been reviewed by the team. bug Indicates an unexpected problem or an unintended behavior. labels May 11, 2021
@lauren-mills lauren-mills added this to the R13 milestone May 11, 2021
@lauren-mills lauren-mills self-assigned this May 11, 2021
@lauren-mills lauren-mills mentioned this issue May 11, 2021
Merged
@lauren-mills lauren-mills changed the title SVG Icons don't load in teams. Affects Core Assistant and Enterprise Assistant SVG Icons don't load in Teams. Affects Core Assistant and Enterprise Assistant May 11, 2021
@sgellock
Copy link
Member

Shiproom - approved

@sgellock sgellock added the ShipRoom-Approved Ship room has approved this issue for the release label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauren-mills lauren-mills

Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release
Projects
None yet
Milestone
R13
Development

Successfully merging a pull request may close this issue.

fix: Convert svg icons to PNG to fix broken images in Teams microsoft/botframework-components
2 participants
@sgellock @lauren-mills