Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SendMessageToTeamsChannel action needs to use the new TeamsInfo.SendMessageToTeamsChannelAsync #1169

Closed
EricDahlvang opened this issue Jun 29, 2021 · 0 comments · Fixed by #1174
Closed

SendMessageToTeamsChannel action needs to use the new TeamsInfo.SendMessageToTeamsChannelAsync #1169

EricDahlvang opened this issue Jun 29, 2021 · 0 comments · Fixed by #1174
Assignees
@EricDahlvang
Labels
Area: Packages: Teams Relating to the Teams bot component package. feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Milestone
R14

Comments

@EricDahlvang
Copy link
Member

Is your feature request related to a problem? Please describe.

The Teams package currently only supports BotFrameworkAdapter for SendMessageToTeamsChannelAsync. A new method has been created on TeamsInfo which is more CloudAdpter friendly:
https:/microsoft/botbuilder-dotnet/pull/5728/files

SendMessageToTeamsChannel action needs to be updated to use it:
https:/microsoft/botframework-components/blob/main/packages/Teams/dotnet/Actions/SendMessageToTeamsChannel.cs#L121

reference:
#1150
microsoft/botbuilder-dotnet#5685
@EricDahlvang EricDahlvang added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. Area: Packages: Teams Relating to the Teams bot component package. labels Jun 29, 2021
@EricDahlvang EricDahlvang self-assigned this Jun 29, 2021
This was referenced Jun 29, 2021
Merged
Merged
@EricDahlvang EricDahlvang linked a pull request Jun 29, 2021 that will close this issue
fix: Send message to teams channel support both adapters #1174
Merged
@EricDahlvang EricDahlvang added this to the R14 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricDahlvang EricDahlvang

Labels
Area: Packages: Teams Relating to the Teams bot component package. feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
R14
Development

Successfully merging a pull request may close this issue.

fix: Send message to teams channel support both adapters microsoft/botframework-components
1 participant
@EricDahlvang