port: GetMeetingInfo, meeting start/end events #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0ddb1fe)
mdrichardson
changed the title
|
Closing in favor of #1178 due to repo permissions issues with CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: CI tests fail because it relies on unpublished packages.
Addresses .NET: #1138
Addresses .NET: #1139
#minor (have to include since this doesn't fully fix an issue)
Purpose
Add the action,
GetMeetingInfo()Adds the Triggers,
OnTeamsMeetingStart() andOnTeamsMeetingEnd()Tests
I triggered
GetMeetingInfo()to send on Unknown Intent:Meeting start/end events (data is on
activity.value):Feature Plan
This relies on updating to v4.14 of the SDK (which this PR does not do--it's meant to be ready-to-go after that update gets pushed)
I'll start working on the JS versions. Should be ready to review by Wednesday.