Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts-beachball): dont override */9.0-alpha versions specified within apps during release #28584

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 19, 2023

Previous Behavior

every release that bumps inner workspace dependency used within applications will put master in invalid state

image

New Behavior

  • Fixed invalid deps
  • fixed order of generators invocations on beachball release so this wont happen again

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the July Project Cycle Q3 2023 milestone Jul 19, 2023
@Hotell Hotell changed the title Hotell/beachball/fix release dep bump fix(scripts-beachball): dont override */9.0-alpha versions specified within apps during release Jul 19, 2023
@Hotell Hotell marked this pull request as ready for review July 19, 2023 16:53
@Hotell Hotell requested review from a team as code owners July 19, 2023 16:53
@Hotell Hotell enabled auto-merge (squash) July 19, 2023 16:54
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against c3819e59d69a017c61f39d617b84a0fff6cd9fff

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f4b6cca:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 19, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c3819e59d69a017c61f39d617b84a0fff6cd9fff (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell merged commit 8ba163a into microsoft:master Jul 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants