Add admin protocol for DAC #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shueybubbles
requested review from
apoorvdeshmukh,
stuartpa,
kenvanhyning and
JyotikaGargg
|
Note that I added a test but a full test run against the |
stuartpa
reviewed
May 25, 2023
| @@ -1,3 +1,4 @@ | |||
| //go:build go1.10 | |||
There was a problem hiding this comment.
Should we remove one of these? #Resolved
There was a problem hiding this comment.
no, the go tooling auto-injected the second one
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 74.53% 74.06% -0.48%
==========================================
Files 29 29
Lines 5592 5613 +21
==========================================
- Hits 4168 4157 -11
- Misses 1179 1208 +29
- Partials 245 248 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
I've attempted to adhere to this spec for DAC: https://learn.microsoft.com/en-us/sql/database-engine/configure-windows/diagnostic-connection-for-database-administrators?view=sql-server-ver15
The doc confuses me a bit. I don't know how an app is supposed to tell the difference between
admin:<instance_name>andadmin:<server_name>The driver requires the full
admin:server\instancesyntax or separate parameters forserverandprotocol.