Add disposal of NpgsqlDataSource after opening connection #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dluc
requested changes
Sep 5, 2024
…th 'await using' for NpgsqlDataSource
dluc
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
See #679.
High level description (Approach, Design)
If I call
ImportDocumentAsyncand thenAskAsync, after the execution I see that two sessions are still in the list:This PR adds the disposal the NpgsqlDataSource after each connection. In this way, no pending sessions remain when the execution completes.
NOTE: for the moment, I have left theIDisposableinterface on PostgresDbClient.cs (with an empty implementation for reference), but actually it is no longer necessary, as explained in #679 (comment). So, I think it could be safely removed.