Skip to content

Commit

Permalink
Refactor to add the boolean parameter at the end
Browse files Browse the repository at this point in the history
  • Loading branch information
@Ndiritu
Ndiritu committed Oct 7, 2024
1 parent 4837b52 commit d5dc8f9
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 26 deletions.
16 changes: 8 additions & 8 deletions .../abstractions/src/main/java/com/microsoft/kiota/serialization/KiotaJsonSerialization.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ private KiotaJsonSerialization() {}
* @throws IOException when the stream cannot be closed or read.
*/
@Nonnull public static <T extends Parsable> InputStream serializeAsStream(
final boolean serializeOnlyChangedValues, @Nonnull final T value) throws IOException {
@Nonnull final T value, final boolean serializeOnlyChangedValues) throws IOException {
return KiotaSerialization.serializeAsStream(
CONTENT_TYPE, serializeOnlyChangedValues, value);
CONTENT_TYPE, value, serializeOnlyChangedValues);
}

/**
Expand All @@ -61,9 +61,9 @@ private KiotaJsonSerialization() {}
* @throws IOException when the stream cannot be closed or read.
*/
@Nonnull public static <T extends Parsable> String serializeAsString(
final boolean serializeOnlyChangedValues, @Nonnull final T value) throws IOException {
@Nonnull final T value, final boolean serializeOnlyChangedValues) throws IOException {
return KiotaSerialization.serializeAsString(
CONTENT_TYPE, serializeOnlyChangedValues, value);
CONTENT_TYPE, value, serializeOnlyChangedValues);
}

/**
Expand All @@ -87,10 +87,10 @@ private KiotaJsonSerialization() {}
* @throws IOException when the stream cannot be closed or read.
*/
@Nonnull public static <T extends Parsable> InputStream serializeAsStream(
final boolean serializeOnlyChangedValues, @Nonnull final Iterable<T> values)
@Nonnull final Iterable<T> values, final boolean serializeOnlyChangedValues)
throws IOException {
return KiotaSerialization.serializeAsStream(
CONTENT_TYPE, serializeOnlyChangedValues, values);
CONTENT_TYPE, values, serializeOnlyChangedValues);
}

/**
Expand All @@ -114,10 +114,10 @@ private KiotaJsonSerialization() {}
* @throws IOException when the stream cannot be closed or read.
*/
@Nonnull public static <T extends Parsable> String serializeAsString(
final boolean serializeOnlyChangedValues, @Nonnull final Iterable<T> values)
@Nonnull final Iterable<T> values, final boolean serializeOnlyChangedValues)
throws IOException {
return KiotaSerialization.serializeAsString(
CONTENT_TYPE, serializeOnlyChangedValues, values);
CONTENT_TYPE, values, serializeOnlyChangedValues);
}

/**
Expand Down
28 changes: 14 additions & 14 deletions ...ents/abstractions/src/main/java/com/microsoft/kiota/serialization/KiotaSerialization.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ private KiotaSerialization() {}
*/
@Nonnull public static <T extends Parsable> InputStream serializeAsStream(
@Nonnull final String contentType, @Nonnull final T value) throws IOException {
return serializeAsStream(contentType, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES, value);
return serializeAsStream(contentType, value, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES);
}

/**
Expand All @@ -44,8 +44,8 @@ private KiotaSerialization() {}
*/
@Nonnull public static <T extends Parsable> InputStream serializeAsStream(
@Nonnull final String contentType,
final boolean serializeOnlyChangedValues,
@Nonnull final T value)
@Nonnull final T value,
final boolean serializeOnlyChangedValues)
throws IOException {
Objects.requireNonNull(value);
try (final SerializationWriter writer =
Expand All @@ -66,7 +66,7 @@ private KiotaSerialization() {}
@Nonnull public static <T extends Parsable> String serializeAsString(
@Nonnull final String contentType, @Nonnull final T value) throws IOException {
Objects.requireNonNull(value);
return serializeAsString(contentType, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES, value);
return serializeAsString(contentType, value, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES);
}

/**
Expand All @@ -80,12 +80,12 @@ private KiotaSerialization() {}
*/
@Nonnull public static <T extends Parsable> String serializeAsString(
@Nonnull final String contentType,
final boolean serializeOnlyChangedValues,
@Nonnull final T value)
@Nonnull final T value,
final boolean serializeOnlyChangedValues)
throws IOException {
Objects.requireNonNull(value);
try (final InputStream stream =
serializeAsStream(contentType, serializeOnlyChangedValues, value)) {
serializeAsStream(contentType, value, serializeOnlyChangedValues)) {
return new String(Compatibility.readAllBytes(stream), CHARSET_NAME);
}
}
Expand All @@ -102,7 +102,7 @@ private KiotaSerialization() {}
@Nonnull final String contentType, @Nonnull final Iterable<T> values)
throws IOException {
Objects.requireNonNull(values);
return serializeAsStream(contentType, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES, values);
return serializeAsStream(contentType, values, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES);
}

/**
Expand All @@ -116,8 +116,8 @@ private KiotaSerialization() {}
*/
@Nonnull public static <T extends Parsable> InputStream serializeAsStream(
@Nonnull final String contentType,
final boolean serializeOnlyChangedValues,
@Nonnull final Iterable<T> values)
@Nonnull final Iterable<T> values,
final boolean serializeOnlyChangedValues)
throws IOException {
Objects.requireNonNull(values);
try (final SerializationWriter writer =
Expand All @@ -139,7 +139,7 @@ private KiotaSerialization() {}
@Nonnull final String contentType, @Nonnull final Iterable<T> values)
throws IOException {
Objects.requireNonNull(values);
return serializeAsString(contentType, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES, values);
return serializeAsString(contentType, values, DEFAULT_SERIALIZE_ONLY_CHANGED_VALUES);
}

/**
Expand All @@ -153,12 +153,12 @@ private KiotaSerialization() {}
*/
@Nonnull public static <T extends Parsable> String serializeAsString(
@Nonnull final String contentType,
final boolean serializeOnlyChangedValues,
@Nonnull final Iterable<T> values)
@Nonnull final Iterable<T> values,
final boolean serializeOnlyChangedValues)
throws IOException {
Objects.requireNonNull(values);
try (final InputStream stream =
serializeAsStream(contentType, serializeOnlyChangedValues, values)) {
serializeAsStream(contentType, values, serializeOnlyChangedValues)) {
return new String(Compatibility.readAllBytes(stream), CHARSET_NAME);
}
}
Expand Down
8 changes: 4 additions & 4 deletions ...bstractions/src/test/java/com/microsoft/kiota/serialization/SerializationHelpersTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ void serializesAllValuesInBackedModel() throws IOException {
// Sets the backing store to be initialized. No properties are dirty
entity.getBackingStore().setIsInitializationCompleted(true);

final String result = KiotaJsonSerialization.serializeAsString(false, entity);
final String result = KiotaJsonSerialization.serializeAsString(entity, false);

assertFalse(entity.getBackingStore().getReturnOnlyChangedValues());
assertEquals("{\"id\":\"123\",\"officeLocation\":\"Nairobi\"}", result);

final String collectionResult =
KiotaJsonSerialization.serializeAsString(
false, new ArrayList<>(Arrays.asList(entity)));
new ArrayList<>(Arrays.asList(entity)), false);

assertEquals("[{\"id\":\"123\",\"officeLocation\":\"Nairobi\"}]", collectionResult);
}
Expand All @@ -138,14 +138,14 @@ void serializesChangedValuesInBackedModel() throws IOException {
entity.setOfficeLocation("Nairobi");
entity.getBackingStore().setIsInitializationCompleted(true);

final String result = KiotaJsonSerialization.serializeAsString(true, entity);
final String result = KiotaJsonSerialization.serializeAsString(entity, true);

assertFalse(entity.getBackingStore().getReturnOnlyChangedValues());
assertEquals("{}", result);

final String collectionResult =
KiotaJsonSerialization.serializeAsString(
true, new ArrayList<>(Arrays.asList(entity)));
new ArrayList<>(Arrays.asList(entity)), true);
assertEquals("[{}]", collectionResult);
}

Expand Down

0 comments on commit d5dc8f9

Please sign in to comment.