efficiency concerns for more directly assert-able types

json_parse_node.go

@@ -417,27 +417,25 @@ func (n *JsonParseNode) GetStringValue() (*string, error) {
  if isNil(n) || isNil(n.value) {
  return nil, nil
  }
- var val string
 
- if err := as(n.value, &val); err != nil {
- return nil, err
+ val, ok := n.value.(*string)
+ if !ok {
+ return nil, fmt.Errorf("type '%T' is not compatible with type string", n.value)
  }
-
- return &val, nil
+ return val, nil
 }
 
 // GetBoolValue returns a Bool value from the nodes.
 func (n *JsonParseNode) GetBoolValue() (*bool, error) {
  if isNil(n) || isNil(n.value) {
  return nil, nil
  }
- var val bool
 
- if err := as(n.value, &val); err != nil {
- return nil, err
+ val, ok := n.value.(*bool)
+ if !ok {
+ return nil, fmt.Errorf("type '%T' is not compatible with type bool", n.value)
  }
-
- return &val, nil
+ return val, nil
 }
 
 // GetInt8Value returns a int8 value from the nodes.

json_parse_node_test.go

@@ -341,7 +341,7 @@ func TestJsonGetStringValue(t *testing.T) {
  Title: "Integer",
  Input: []byte(`1`),
  Expected: (*string)(nil),
- Error: errors.New("value '1' is not compatible with type string"),
+ Error: errors.New("type '*float64' is not compatible with type string"),
  },
  }
 
@@ -381,13 +381,13 @@ func TestJsonGetBoolValue(t *testing.T) {
  Title: "Integer",
  Input: []byte(`1`),
  Expected: (*bool)(nil),
- Error: errors.New("value '1' is not compatible with type bool"),
+ Error: errors.New("type '*float64' is not compatible with type bool"),
  },
  {
  Title: "String",
  Input: []byte(`"true"`),
  Expected: (*bool)(nil),
- Error: errors.New("value 'true' is not compatible with type bool"),
+ Error: errors.New("type '*string' is not compatible with type bool"),
  },
  }