ObsoleteAttribute on method parameters #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
reviewed
Aug 24, 2024
There was a problem hiding this comment.
Thank you for the contribution.
While the addition of the unit test is a great way to avoid regressions over time, I'm not sure adding an integration test like it is defined now adds a lot of value. Can you provide more context here please?
Can you also add a changelog entry please? (Unreleased, changed)
|
The integration test uses a snippet from the Apple API I used for testing. It's OK for me to remove it |
trejjam
force-pushed
the
feature/obsolete-parameters
branch
from
3171a1b
to
5feda01
Compare
I'd like @andrueastman opinion on this one, but as it is, I think we should remove it. |
trejjam
force-pushed
the
feature/obsolete-parameters
branch
from
5feda01
to
5e547ef
Compare
|
Done |
baywet
previously approved these changes
Aug 26, 2024
auto-merge was automatically disabled
August 26, 2024 12:08
Head branch was pushed to by a user without write access
trejjam
force-pushed
the
feature/obsolete-parameters
branch
from
5e547ef
to
88aedfd
Compare
|
There was a merge conflict in the CHANGELOG.md |
baywet
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
using the Apple Store Connect API I found out that Kiota generates ObsoleteAttribute on methor parameters. That is, unfortunately, invalid code see ObsoleteAttribute.
This PR should fix it