Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal/Question: Add Tooltips to TabView's scroll buttons #2345

Closed
Felix-Dev opened this issue Apr 27, 2020 · 4 comments · Fixed by #2369
Closed

Proposal/Question: Add Tooltips to TabView's scroll buttons #2345

Felix-Dev opened this issue Apr 27, 2020 · 4 comments · Fixed by #2369
Assignees
@stmoy
Labels
area-TabView feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@Felix-Dev
Copy link
Contributor

Proposal/Question: Add Tooltips to TabView's scroll buttons

This is more a question than a proposal as of now:

Edge UWP's TabView scroll buttons have Tooltips describing their functionality:
image image

Should we also add those Tooltips to WinUI's TabView?

Based on some quick testing, Firefox' tab scroll buttons don't have tooltips. For Edgium, I could not get these buttons to show up at all (tabs just got smaller and smaller until I could create no more tabs).
@Felix-Dev Felix-Dev added the feature proposal New feature proposal label Apr 27, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Apr 27, 2020
@ranjeshj ranjeshj assigned aaronstebner and stmoy and unassigned aaronstebner Apr 28, 2020
@ranjeshj
Copy link
Contributor

@stmoy This sounds like a reasonable request...

@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Apr 29, 2020
@stmoy
Copy link
Contributor

stmoy commented May 1, 2020

Seems reasonable to me too. We'll need to make sure that the strings are localized, but this otherwise seems straightforward.

@Felix-Dev
Copy link
Contributor Author

@stmoy I would like to work on this then. I would follow the precedence set in my PR #2022 where I only had to create the resources for US English with the localizations added to WinUI in a later PR by the team.

@Felix-Dev Felix-Dev mentioned this issue May 1, 2020
Merged
@ranjeshj ranjeshj added area-TabView team-Controls Issue for the Controls team labels May 1, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

🎉This issue was addressed in #2369, which has now been successfully released as Microsoft.UI.Xaml v2.5.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stmoy stmoy

Labels
area-TabView feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TabView: Add tooltips to its scrolling buttons. Felix-Dev/microsoft-ui-xaml
5 participants
@Felix-Dev @aaronstebner @stmoy @ranjeshj @msft-github-bot