Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enum SQLServerSortOrder become public #2405

Merged
merged 1 commit into from
May 10, 2024

Conversation

mpwong852
Copy link
Contributor

Issue #2404

Make this enum to be public, so that people can create "SQLServerMetaData" like below:

new SQLServerMetaData("row_id", java.sql.Types.INTEGER, 0, 0, true, false, SQLServerSortOrder.Unspecified, -1)

Issue microsoft#2404 

Make this enum to be public, so that people can create "SQLServerMetaData" like below:

new SQLServerMetaData("row_id", java.sql.Types.INTEGER, 0, 0, true, false, SQLServerSortOrder.Unspecified, -1)
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.21%. Comparing base (f452337) to head (d74824e).

❗ Current head d74824e differs from pull request most recent head 8b1140f. Consider uploading reports for the commit 8b1140f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2405      +/-   ##
============================================
+ Coverage     49.88%   50.21%   +0.33%     
- Complexity     3827     3841      +14     
============================================
  Files           145      145              
  Lines         33360    33360              
  Branches       5654     5654              
============================================
+ Hits          16642    16753     +111     
+ Misses        14349    14211     -138     
- Partials       2369     2396      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkyc
Copy link
Contributor

tkyc commented May 7, 2024

FYI for the team. This is used in SQLServerMetaData and not SQLServerDatabaseMetaData. SQLServerDatabaseMetaData is the class that implements the JDBC metadata API and so SQLServerMetaData is unique to our driver. This is a harmless change.

@Jeffery-Wasty Jeffery-Wasty added this to the 12.7.1 milestone May 8, 2024
@Jeffery-Wasty Jeffery-Wasty linked an issue May 8, 2024 that may be closed by this pull request
@Jeffery-Wasty Jeffery-Wasty merged commit 561bb4f into microsoft:main May 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

SQLServerMetaData Constructor Issue
4 participants