Implement DML on device copy for Lora Parameters #22366
Closed
+274
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
requested review from
PatriceVignola,
smk2007,
baijumeswani and
jeffbloo
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| void* dstData = dst.MutableDataRaw(); | ||
| ID3D12Resource* srcData = GetD3D12ResourceFromAllocation(nullptr, src.DataRaw()); | ||
|
|
||
| const uint64_t srcOffset = 0; |
Check warning
Code scanning / PREfast
The const variable 'srcOffset' can be computed at compile-time. Consider using constexpr (con.5). Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change now supports copying lora parameters to DML EP memory when adapter is loaded.
The change incorporates necessary changes to DML EP.
Motivation and Context
Lora needs an ability to copy to DML EP memory.
Addresses: #22336
Co-authored-by: @PatriceVignola