feat(webkit): enable user-data-dir tests for all platforms (#646)

Fixes #560
microsoft · Jan 25, 2020 · b4b7c5e · b4b7c5e
1 parent 63d5a73
commit b4b7c5e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
  "playwright": {
  "chromium_revision": "733125",
  "firefox_revision": "1018",
- "webkit_revision": "1111"
+ "webkit_revision": "1112"
  },
  "scripts": {
  "unit": "node test/test.js",

diff --git a/src/server/webkit.ts b/src/server/webkit.ts
@@ -79,9 +79,9 @@ export class WebKit implements BrowserType {
 
  let userDataDir: string;
  let temporaryUserDataDir: string | null = null;
- const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir'));
+ const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir='));
  if (userDataDirArg) {
- userDataDir = userDataDirArg.substr('--user-data-dir'.length).trim();
+ userDataDir = userDataDirArg.substr('--user-data-dir='.length).trim();
  } else {
  userDataDir = await mkdtempAsync(WEBKIT_PROFILE_PATH);
  temporaryUserDataDir = userDataDir;

diff --git a/test/launcher.spec.js b/test/launcher.spec.js
@@ -288,7 +288,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
  });
  });
 
- describe.skip(WEBKIT)('Playwright.launch({userDataDir})', function() {
+ describe('Playwright.launch({userDataDir})', function() {
  it('userDataDir option', async({server}) => {
  const userDataDir = await mkdtempAsync(TMP_FOLDER);
  const options = Object.assign({userDataDir}, defaultBrowserOptions);