Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] text= selector to match <input type="submit" value="myinput"> #1427

Closed
aesyondu opened this issue Mar 19, 2020 · 0 comments · Fixed by #1657
Closed

[Feature] text= selector to match <input type="submit" value="myinput"> #1427

aesyondu opened this issue Mar 19, 2020 · 0 comments · Fixed by #1657

Comments

@aesyondu
Copy link
Contributor

Test case: aesyondu@8548b3d

Would it make sense to allow text selector for input element of type submit, in the same way as a button element?

<button>mybutton</button> works, but <input type="submit" value="myinput"> doesn't, even though they have very similar functionality.

I created a test case above, and played around with textSelectorEngine.ts, but couldn't figure out how to make the input test case pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant