-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing a few device defs for landscape variants #606
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Randomly noticed that a few items didn't specify a "landscape" device:
Missing device for "iPhone 11 landscape"
Missing device for "iPhone 11 Pro landscape"
Missing device for "iPhone 11 Pro Max landscape"
Missing device for "Microsoft Lumia 550 landscape"
... So I hacked a quick linter to verify:
OUTPUT
Although, that "Lumia 550" definition looks possibly suspicious.
playwright/src/deviceDescriptors.ts
Lines 491 to 500 in b4209e9
It looks like the width > height, so it's possibly already the landscape definition, but incorrectly labeled (and we're missing the portrait definition).
The text was updated successfully, but these errors were encountered: