docs(api): elaborate on fill vs type #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Mar 31, 2020
docs/api.md
Outdated
| @@ -1585,7 +1585,7 @@ Shortcut for [page.mainFrame().title()](#frametitle). | |||
| - `timeout` <[number]> Maximum time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. The default value can be changed by using the [browserContext.setDefaultTimeout(timeout)](#browsercontextsetdefaulttimeouttimeout) or [page.setDefaultTimeout(timeout)](#pagesetdefaulttimeouttimeout) methods. | |||
| - returns: <[Promise]> | |||
|
|
|||
| Sends a `keydown`, `keypress`/`input`, and `keyup` event for each character in the text. | |||
| Sends a `keydown`, `keypress`/`input`, and `keyup` event for each character in the text. `page.type` can be used to send fine-grained keyboard events. To fill text in form fields, use [`page.fill`](#pagefillselector-value-options). | |||
There was a problem hiding this comment.
fill text->fill values?- maybe add an opposite statement to the fill method?
There was a problem hiding this comment.
Thanks! Made both the changes
arjunattam
force-pushed
the
fill-vs-type
branch
from
d24e01b
to
c56f216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1473