fix(downloads): fix acceptDownloads complaint (#1777)
#1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fail with: ``` NON-TEST ERROR #1: UNHANDLED PROMISE REJECTION Error: Pass { acceptDownloads: true } when you are creating your browser context. ``` which shows the issue we were running into.
This patch fixes `download.path()` throwing an error that `acceptDownloads` is not set when using a download within a `page.on` handler even when `acceptDownloads` had been set to `true`; Fixes microsoft#1777
|
|
pavelfeldman
approved these changes
Apr 22, 2020
Per-review feedback, just let this timeout if it's not working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes
download.path()throwing an error thatacceptDownloadsis not set when using a download within apage.onhandler even whenacceptDownloadshad been set totrue.See this comment for an explanation of the issue.
If you checkout fbc52e7, you can run the newly added tests with the previous code and observe the failure.
Fixes #1777